Skip to content

SNOW-3990655: support table_properties in iceberg_config for Iceberg … - #4330

Merged
sfc-gh-yuwang merged 5 commits into
mainfrom
felix-he-SNOW-3990655-iceberg-table-properties
Sep 3, 2026
Merged

SNOW-3990655: support table_properties in iceberg_config for Iceberg …#4330
sfc-gh-yuwang merged 5 commits into
mainfrom
felix-he-SNOW-3990655-iceberg-table-properties

Conversation

@sfc-gh-fhe

@sfc-gh-fhe sfc-gh-fhe commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

…CREATE / CTAS

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-fhe
sfc-gh-fhe requested a review from a team as a code owner August 25, 2026 14:19
@sfc-gh-fhe
sfc-gh-fhe force-pushed the felix-he-SNOW-3990655-iceberg-table-properties branch 2 times, most recently from e11ae48 to ffa3ed1 Compare August 25, 2026 14:31
@codecov-commenter

codecov-commenter commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.25%. Comparing base (f2c0f1c) to head (59a159d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4330   +/-   ##
=======================================
  Coverage   95.24%   95.25%           
=======================================
  Files         171      171           
  Lines       44757    44771   +14     
  Branches     7685     7687    +2     
=======================================
+ Hits        42631    42645   +14     
  Misses       1339     1339           
  Partials      787      787

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-fhe
sfc-gh-fhe force-pushed the felix-he-SNOW-3990655-iceberg-table-properties branch from ffa3ed1 to a7e9ac0 Compare August 25, 2026 15:14
@sfc-gh-yuwang

sfc-gh-yuwang commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

there are some test failure in merge gate, please take a look

sfc-gh-jzeng
sfc-gh-jzeng reviewed Aug 31, 2026
View reviewed changes
Comment thread src/snowflake/snowpark/_internal/analyzer/analyzer_utils.py Outdated
sfc-gh-jzeng
sfc-gh-jzeng reviewed Sep 1, 2026
View reviewed changes
Comment thread src/snowflake/snowpark/_internal/analyzer/analyzer_utils.py Outdated
Comment thread tests/unit/test_analyzer_util_suite.py
@sfc-gh-fhe
sfc-gh-fhe force-pushed the felix-he-SNOW-3990655-iceberg-table-properties branch from 46cd992 to 9ee4674 Compare September 3, 2026 17:33
@sfc-gh-yuwang
sfc-gh-yuwang enabled auto-merge (squash) September 3, 2026 18:27
@sfc-gh-yuwang
sfc-gh-yuwang merged commit 550a0c0 into main Sep 3, 2026
27 of 30 checks passed
@sfc-gh-yuwang
sfc-gh-yuwang deleted the felix-he-SNOW-3990655-iceberg-table-properties branch September 3, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-yuwang sfc-gh-yuwang sfc-gh-yuwang approved these changes
@sfc-gh-jzeng sfc-gh-jzeng sfc-gh-jzeng approved these changes
@sfc-gh-mayliu sfc-gh-mayliu Awaiting requested review from sfc-gh-mayliu sfc-gh-mayliu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers
@sfc-gh-bkogan sfc-gh-bkogan Awaiting requested review from sfc-gh-bkogan sfc-gh-bkogan is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-fhe @codecov-commenter @sfc-gh-yuwang @sfc-gh-jzeng